Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove command line option -B which could be used to override the architecture #3796

Merged
merged 1 commit into from
Jan 17, 2020

Conversation

fingolfin
Copy link
Member

The documentation for it claimed that "[u]nder rare circumstances, it
may be necessary to override this name" but I simply can't come up
with any that are not contrived and highly dangerous, and which are not
more easily resolved by renaming or copying a few bin subdirectories
inside packages.

That of course just means my imagination might be limited. I wonder if
some of the people who were around (?) when this was added might
know the original motivation and whether there could be circumstances
now where this would still be useful.

The documentation for it claimed that "[u]nder rare circumstances, it
may be necessary to override this name" but I simply can't come up
with any that are not contrived and highly dangerous, and which are not
more easily resolved by renaming or copying a few `bin` subdirectories
inside packages
@fingolfin fingolfin added the release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes label Dec 20, 2019
@ChrisJefferson
Copy link
Contributor

I have half a memory of discussing this years ago with @frankluebeck , so I will mention him here just so he is notified, in case he wants to comment.

Many apologises if I misremember!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 84.689% when pulling c9f7442 on fingolfin:mh/no-arch-override into c10d5a4 on gap-system:master.

@fingolfin
Copy link
Member Author

Yeah I already requested reviews from @frankluebeck @ThomasBreuer @stevelinton in the hopes that they can shed light on this.

I think the option may have been more useful with the old build system that was in use until GAP 4.8 ?

@fingolfin
Copy link
Member Author

@frankluebeck @ThomasBreuer @stevelinton perhaps you missed this because of Christmas: this PR removes the -B option for overriding the architecture. Any concerns about this?

@frankluebeck
Copy link
Member

I vaguely remember that the -B option was used in earlier times in network installations in inhomogeneous networks (machines with different architectures, different optimizations for some machines,...). Later I had introduced a mechanism using the CONFIGNAME variable.
With the current build system both are probably no longer needed.

@ChrisJefferson ChrisJefferson merged commit d0ea5c0 into gap-system:master Jan 17, 2020
@fingolfin fingolfin deleted the mh/no-arch-override branch January 17, 2020 10:37
@ThomasBreuer ThomasBreuer self-assigned this Feb 17, 2021
@ThomasBreuer ThomasBreuer added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Feb 17, 2021
@ThomasBreuer ThomasBreuer removed their assignment Feb 17, 2021
@fingolfin fingolfin changed the title Remove -B option for overriding the architecture Remove command line option -B which could be used to override the architecture Aug 17, 2022
@fingolfin fingolfin added the kind: removal or deprecation A feature was removed or deprecated / made obsolete label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: removal or deprecation A feature was removed or deprecated / made obsolete release notes: added PRs introducing changes that have since been mentioned in the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants