Improved code for NormalSubgroups #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there are many complements, take affine action on cohomology group to determine which ones are invariant, rather than forming subgroups and testing normality.
|
Thanks @hulpke for setting up pull requests! I can confirm that this patch passes the tests and fixes issue #369 (and I played a bit with finding normal subgroups in other groups). I admit that I do not fully understand the mathematics behind this fix (yet), but I see that there are helpful comments there, so I will spend some more time on this. I suggest to clean up commented out code from the patch though. |
|
Nice improvement, thank you. Seems to be faster when it takes longer time to compute normal subgroups. |
|
Thanks @hulpke and also @markuspf and @hungaborhorvath for testing. Let's merge it then? |
markuspf
added a commit
that referenced
this pull request
Nov 30, 2015
Improved code for NormalSubgroups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt of a Pull Request:
If there are many complements, take affine action on cohomology group to
determine which ones are invariant, rather than forming subgroups and
testing normality. This gives a substantial speedup.