A bunch of HPC-GAP fixes by Reimer #3742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making the method cache entries public avoids potential trouble with method cache lookup. Disabling guards for cache access also eliminates overhead on a couple of critical paths.
They were in boehm_gc.c, but in reality these functions are not Bohem specific but rather HPC-GAP specific.
fingolfin
added
topic: HPC-GAP
ChrisJefferson
approved these changes
Nov 14, 2019
rbehrends
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bunch of commits based on commits by @rbehrends from PR #2845 and PR #3734 (in some cases I extracted parts of a commit by Reimer into a new commit.
I think these are all safe to merge right away, and then reviewing the two PRs above becomes a little bit easier, I hope.