Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence InfoDebug in a test that loads Crisp package #3726

Merged
merged 1 commit into from
Nov 7, 2019
Merged

Silence InfoDebug in a test that loads Crisp package #3726

merged 1 commit into from
Nov 7, 2019

Conversation

olexandr-konovalov
Copy link
Member

@olexandr-konovalov olexandr-konovalov commented Nov 6, 2019 •
edited
Loading

After #3694, a warning

DeclareGlobalFunction: too many arguments

is shown when Crisp is loaded. This PR temporary tweaks InfoDebug to silence it.

This was referenced Nov 6, 2019
Closed
Merged
@olexandr-konovalov
Copy link
Member Author

Something is broken with gcovr:

> > > gap> gap> Scanning for coverage data...
gap> gap> > > > > >   coverage/testtravis.coverage
gap> > Merging 1 coverage files...
> > > > > > > > > > Outputting JSON for Codecov...
> > > Outputting JSON for Coveralls...
> > > > > > > gap> +[[ -f gap-coveralls.json ]]
+python etc/ci-gcovr-coverage.py -r . --output c-coveralls.json --exclude-directories pkg/ --exclude-directories extern/
Traceback (most recent call last):
  File "etc/ci-gcovr-coverage.py", line 49, in <module>
    from gcovr.gcov import get_datafiles, process_existing_gcov_file, process_datafile
ImportError: cannot import name get_datafiles

Silence InfoDebug in a test that loads Crisp package
f6aabba 
After gap-system#3694, a warning
`DeclareGlobalFunction: too many arguments` is shown when Crisp
is loaded.
@fingolfin
Copy link
Member

fingolfin commented Nov 7, 2019 •
edited
Loading

@alex-konovalov can you please rebase to hopefully fix the CI tests?

Whoops, I should have reloaded the window first, you already did that :-)

@olexandr-konovalov
Copy link
Member Author

@fingolfin tests passed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 84.516% when pulling f6aabba on alex-konovalov:silence-warning into cd0dd8b on gap-system:master.

@olexandr-konovalov olexandr-konovalov added release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: tests issues or PRs related to tests labels Nov 7, 2019
@olexandr-konovalov olexandr-konovalov merged commit b95f3c5 into gap-system:master Nov 7, 2019
@olexandr-konovalov olexandr-konovalov deleted the silence-warning branch November 7, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: tests issues or PRs related to tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@olexandr-konovalov @fingolfin @coveralls