-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip test involving fork() on windows #3507
Conversation
Thanks, but this is not enough. As #3506 says, even the first iteration hangs it. You need also to tweak parameters in
What worked for me was simple |
This otherwise is far too slow on 64 bit windows. Fixes gap-system#3506
Codecov Report
@@ Coverage Diff @@
## master #3507 +/- ##
==========================================
+ Coverage 85.42% 85.43% +0.01%
==========================================
Files 699 699
Lines 346778 346778
==========================================
+ Hits 296229 296270 +41
+ Misses 50549 50508 -41
|
I've decided to simply don't run this part of the test file at all on Windows. It's IMHO just not worth the hassle to try to just launch 1-2 child processes: we already have other tests which do that, so we don't gain anything from it. |
Ok! I guess I still can test #3513 where this test is not modified? |
@alex-konovalov does your approval of this PR mean that you tested it on Windows / Cygwin and it resolved the issue there? |
No - it's pretty obvious that this test should be excluded from Windows, so my approval is just based on inspecting the diff. |
Argh, I confused the PRs, my bad :-( |
Backported to stable-4.10 in 2dbf56e |
This otherwise is far too slow on 64 bit windows.
Fixes #3506