Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildsys: teach package boostrap to use curl if available #3504

Merged
merged 1 commit into from
Jun 18, 2019

Conversation

fingolfin
Copy link
Member

This allows people to do a package bootstrap on macOS without installing wget,
as curl is installed there by default but wget is not.

Resolves #1866

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: build system labels Jun 16, 2019
@coveralls
Copy link

coveralls commented Jun 16, 2019

Coverage Status

Coverage remained the same at 85.256% when pulling 74f288f on fingolfin:mh/download into ce16a7d on gap-system:master.

@sebasguts
Copy link
Member

looks good to me :)

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #3504 into master will increase coverage by 0.68%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3504      +/-   ##
==========================================
+ Coverage   84.75%   85.43%   +0.68%     
==========================================
  Files         698      699       +1     
  Lines      346577   346766     +189     
==========================================
+ Hits       293728   296252    +2524     
+ Misses      52849    50514    -2335
Impacted Files Coverage Δ
src/gasman.c 86.28% <0%> (-3.66%) ⬇️
src/gap.c 81.18% <0%> (-0.37%) ⬇️
lib/debug.g 23.57% <0%> (ø)
lib/algrep.gi 80.6% <0%> (+0.04%) ⬆️
lib/cyclotom.gi 80.9% <0%> (+0.08%) ⬆️
lib/ratfun.gi 91.19% <0%> (+0.08%) ⬆️
src/plist.c 95.06% <0%> (+0.08%) ⬆️
lib/meataxe.gi 87.54% <0%> (+0.08%) ⬆️
lib/oprtperm.gi 93.75% <0%> (+0.1%) ⬆️
lib/orders.gi 77.01% <0%> (+0.12%) ⬆️
... and 117 more

This allows people to do a package bootstrap on macOS without installing wget,
as curl is installed there by default but wget is not.
@fingolfin fingolfin merged commit f7f36d7 into gap-system:master Jun 18, 2019
@fingolfin fingolfin deleted the mh/download branch June 18, 2019 10:19
@DominikBernhardt DominikBernhardt added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Aug 20, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: build system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Teach "make bootstrap" to use curl if wget is not available
5 participants