Fix corner case in modified Todd-Coxeter when relator is trivial #3311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markuspf
force-pushed
the
fix-cornercase
branch
from
98ccd30 to
8690809
Compare
markuspf
added
kind: bug
Member
Author
|
Arguably we could also filter out trivial relators when creating a finitely presented group, but this change makes the code safer regardless. |
markuspf
requested review from
fingolfin and
hulpke
and removed request for
hulpke
markuspf
commented
Feb 19, 2019
lib/sgpres.gi
Outdated
| SortBy(ri,Length); | ||
| A:=Concatenation([1..m],-[1..m]); | ||
|
|
||
hulpke
approved these changes
Feb 19, 2019
Contributor
hulpke
left a comment
hulpke
left a comment
There was a problem hiding this comment.
Yes, this will remove this problem. (It is good to do this in the TC only, but keep the trivial relator in the group.)
fingolfin
requested changes
Feb 20, 2019
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Please change the commit message to something more self-explanatory, something that does not require access to an unspecified external entity in order to make sense. E.g.
"Fix bug in coset enumeration for fp groups with trivial relator"
Other than this, this PR of course seems fine, thanks
lib/sgpres.gi
Outdated
| SortBy(ri,Length); | ||
| A:=Concatenation([1..m],-[1..m]); | ||
|
|
||
markuspf
force-pushed
the
fix-cornercase
branch
from
8690809 to
5a8cbed
Compare
Codecov Report
@@ Coverage Diff @@
## master #3311 +/- ##
==========================================
- Coverage 85.23% 85.23% -0.01%
==========================================
Files 696 695 -1
Lines 344083 343780 -303
==========================================
- Hits 293278 293013 -265
+ Misses 50805 50767 -38
|
markuspf
force-pushed
the
fix-cornercase
branch
from
5a8cbed to
ce0ad33
Compare
fingolfin
changed the title
Merged
olexandr-konovalov
removed
the
release notes: to be added
olexandr-konovalov
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.