Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CloseMutableBasis now returns something #3247

Merged
merged 1 commit into from
Jan 30, 2019

Conversation

ThomasBreuer
Copy link
Contributor

Up to now, CloseMutableBasis had no return value.
Now it returns true if the basis was extended and false otherwise.

This saves work in situations where one builds a basis by
adding vectors, and where one wants to know which ones really
extended the current basis.

Up to now, `CloseMutableBasis` had no return value.
Now it returns `true` if the basis was extended and `false` otherwise.

This saves work in situations where one builds a basis by
adding vectors, and where one wants to know which ones really
extended the current basis.
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #3247 into master will decrease coverage by <.01%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master    #3247      +/-   ##
==========================================
- Coverage   85.09%   85.09%   -0.01%     
==========================================
  Files         695      695              
  Lines      344336   344346      +10     
==========================================
+ Hits       293024   293032       +8     
- Misses      51312    51314       +2
Impacted Files Coverage Δ
lib/basismut.gd 100% <ø> (ø) ⬆️
lib/algrep.gi 80.6% <100%> (ø) ⬆️
lib/vspcmat.gi 94.5% <100%> (+0.19%) ⬆️
lib/vspcrow.gi 84.63% <100%> (+0.16%) ⬆️
lib/basismut.gi 85.71% <80%> (-0.19%) ⬇️
src/iostream.c 65.01% <0%> (-0.77%) ⬇️
src/stats.c 94.93% <0%> (-0.21%) ⬇️

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0001%) to 84.934% when pulling 48b20f6 on ThomasBreuer:TB_CloseMutableBasis into c381e0c on gap-system:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0001%) to 84.934% when pulling 48b20f6 on ThomasBreuer:TB_CloseMutableBasis into c381e0c on gap-system:master.

Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful!

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Jan 29, 2019
@ThomasBreuer ThomasBreuer merged commit 2196a43 into gap-system:master Jan 30, 2019
@ThomasBreuer ThomasBreuer deleted the TB_CloseMutableBasis branch January 30, 2019 10:56
@PaulaHaehndel PaulaHaehndel added release notes: added PRs introducing changes that have since been mentioned in the release notes and removed release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Apr 23, 2019
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.11.0 milestone Feb 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants