Some more finite field tweaks from from PR #2997 #3137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: kernel
release notes: not needed
fingolfin
force-pushed
the
mh/ffe-more
branch
from
96820d6 to
8309a95
Compare
Codecov Report
@@ Coverage Diff @@
## master #3137 +/- ##
==========================================
- Coverage 83.67% 83.67% -0.01%
==========================================
Files 687 687
Lines 336648 336643 -5
==========================================
- Hits 281695 281687 -8
- Misses 54953 54956 +3
|
fingolfin
force-pushed
the
mh/ffe-more
branch
2 times, most recently
from
546d48c to
7f0b531
Compare
Also improve the error messages for `Z`
stevelinton
approved these changes
Jan 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains some more bits from PR #2997, which again I hope are uncontroversial.
I will shortly update PR #2997 with a version rebased on this PR.