kernel: cleanup FFE code (contains parts of PR #2997) #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... as SUM_FFV uses PROD_FFV
fingolfin
added
topic: kernel
release notes: not needed
Codecov Report
@@ Coverage Diff @@
## master #3121 +/- ##
==========================================
+ Coverage 83.56% 83.56% +<.01%
==========================================
Files 687 688 +1
Lines 336852 336930 +78
==========================================
+ Hits 281499 281570 +71
- Misses 55353 55360 +7
|
fingolfin
requested review from
stevelinton
and removed request for
ChrisJefferson and
markuspf
stevelinton
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up various parts of our FFE code, in a way close to what is done in PR #2997. The hope here is that this PR is uncontroversial, and can be merged soon. Afterwards, we can rebase PR #2997, and then its diffs will be much smaller, and it'll therefore be easier to review and then hopefully can also be merged soon-ish.
@ChrisJefferson the second to last commit in this PR clang-formats two functions in
finfield.c-- I am doing this because they are also clang-formatted in PR #2997, and undoing that would be much more work; by clang-formatting them in this PR, the diff for PR #2997 becomes quite a bit smaller.