Skip to content

Add IsPackageLoaded #2855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ChrisJefferson merged 1 commit into from
Sep 21, 2018
Merged

Add IsPackageLoaded #2855

ChrisJefferson merged 1 commit into from
Sep 21, 2018

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented Sep 20, 2018

Resolves #2842

@mtorpey there you go

@fingolfin fingolfin added kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Sep 20, 2018
@codecov
Copy link

codecov bot commented Sep 21, 2018 •
edited
Loading

Codecov Report

Merging #2855 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2855      +/-   ##
==========================================
+ Coverage   76.09%    76.1%   +<.01%     
==========================================
  Files         480      480              
  Lines      240980   240982       +2     
==========================================
+ Hits       183385   183390       +5     
+ Misses      57595    57592       -3
Impacted Files Coverage Δ
lib/package.gi 71.17% <100%> (+0.02%) ⬆️
hpcgap/lib/hpc/stdtasks.g 64.7% <0%> (+0.76%) ⬆️

wilfwilson
wilfwilson approved these changes Sep 21, 2018
View reviewed changes
Copy link
Member

@wilfwilson wilfwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to have 🙂

@ChrisJefferson ChrisJefferson merged commit 1d1783e into gap-system:master Sep 21, 2018
@fingolfin
Copy link
Member Author

fingolfin commented Sep 21, 2018

@alex-konovalov suggested to backport this to 4.10.

@fingolfin fingolfin deleted the mh/IsPackageLoaded branch September 21, 2018 11:44
@fingolfin
Copy link
Member Author

fingolfin commented Sep 28, 2018

Backported to stable-4.10 as aff1860

@fingolfin fingolfin added backport-to-4.10-DONE release notes: added PRs introducing changes that have since been mentioned in the release notes and removed backport-to-4.10 release notes: to be added PRs introducing changes that should be (but have not yet been) mentioned in the release notes labels Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wilfwilson wilfwilson wilfwilson approved these changes

@olexandr-konovalov olexandr-konovalov Awaiting requested review from olexandr-konovalov

Assignees

No one assigned

Labels

kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fingolfin @wilfwilson @ChrisJefferson