Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernel: reject invalid AND-filters #2756

Merged
merged 2 commits into from
Oct 17, 2018
Merged

kernel: reject invalid AND-filters #2756

merged 2 commits into from
Oct 17, 2018

Commits on Oct 15, 2018

  1. kernel: reject invalid AND-filters 

    Also unify treatment of 'and' for filters in interpreter and executor.

Note that previously, this input was silently accepted:

  gap> Center and IsAssociative;
  <Filter "<<and-filter>>">

This was effectively treated equivalently to `HasCenter and IsAssociative`.
We now reject such code.
    @fingolfin
    fingolfin committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    27185d5 View commit details
    Browse the repository at this point in the history

  2. kernel: also reject invalid AND-filters in compiled code

    @fingolfin
    fingolfin committed Oct 15, 2018
    Configuration menu
    Copy the full SHA
    58d256f View commit details
    Browse the repository at this point in the history