Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor performance improvements, code cleanup and very local fixes #2733

Merged
merged 13 commits into from
Sep 9, 2018
Merged

Minor performance improvements, code cleanup and very local fixes #2733

merged 13 commits into from
Sep 9, 2018

Commits on Sep 6, 2018

  1. FIX: Documentation clarification in SubgroupsSolvableGroup

    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    04c80d8 View commit details
    Browse the repository at this point in the history

  2. ENHANCE: Speed up Socle 

    Remove extra test that is not worth doing.
Immediately add conjugate when forming normal closure.
    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    4aa1666 View commit details
    Browse the repository at this point in the history

  3. ENHANCE: Performance of CompatiblePairs

    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    92cb1a8 View commit details
    Browse the repository at this point in the history

  4. ENHANCE: Subword also applies to elements of FpGroups

    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    a8f8e61 View commit details
    Browse the repository at this point in the history

  5. ENHANCE: Nice method for StructureDescription

    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    82eb95e View commit details
    Browse the repository at this point in the history

  6. FIX: Added warning that primitive groups library is used

    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    2f92e5d View commit details
    Browse the repository at this point in the history

  7. CLEANUP: Added comment and Whitespace fix

    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    41fe45c View commit details
    Browse the repository at this point in the history

  8. CLEANUP: Replace FactorsInt by Factors.

    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    14157d1 View commit details
    Browse the repository at this point in the history

  9. ENHANCE: Aim for intransitive centralizer in NormalSubgroups 

    as this makes a Core computation quicker. This avoids slowdowns in
particular cases such as gap-system#2683

This fixes gap-system#2683

Includes necessary manual example changes.
    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    d9b2efc View commit details
    Browse the repository at this point in the history

  10. CLEANUP: Make MaxesAlmostSimple an operation. 

    This permits packages to overload new methods without touching existing
code.
Also have simple group imply almost simple group.
    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    3c243da View commit details
    Browse the repository at this point in the history

  11. CLEANUP: New attribute AbelianRank 

    Used to clean up generator number arguments in multiple places.
    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    2d2a61a View commit details
    Browse the repository at this point in the history

  12. FIX: IsConjugatorAutomorphism if permutation is mapped to restriction. 

    Also add first cheap cycle structure test to be conjugator automorphism.

This fixes gap-system#2724
    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    474a064 View commit details
    Browse the repository at this point in the history

  13. ENHANCE: Cache the last 5 full-GL niceomorphisms

    @hulpke
    hulpke committed Sep 6, 2018
    Configuration menu
    Copy the full SHA
    f4ede03 View commit details
    Browse the repository at this point in the history