Export READ_ALL_COMMANDS via header file #2707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2707 +/- ##
==========================================
+ Coverage 75.52% 75.52% +<.01%
==========================================
Files 478 478
Lines 241620 241621 +1
==========================================
+ Hits 182488 182492 +4
+ Misses 59132 59129 -3
|
fingolfin
approved these changes
Aug 15, 2018
fingolfin
added
topic: kernel
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #2702, though I am a bit reluctant to give this function more credibility by exporting it through a header file.
Also separate
FuncREAD_ALL_COMMANDS(exported to GAP level) andREAD_ALL_COMMANDS(kernel function) for conistency.