Introduce SetExtraMarkFuncBags #2706
Conversation
src/gasman.h
Outdated
| // ExtraMarkFuncBags, if not NULL, is called during garbage collection | ||
| // This is used for integrating GAP (possibly linked as a shared library) with | ||
| // other code bases which use their own form of garbage collection. For | ||
| // example, with Python (for SageMath) or Julia. |
There was a problem hiding this comment.
Not really for Julia, as we are using the Julia GC there.
There was a problem hiding this comment.
It'd be somewhat helpful if I knew which bits of garbage collection I should care about; at the moment I run with "if it works and tests pass in the master branch, I fire and forget", should I start worrying about boehm and julia gcs?
And if so, I need ways to test them.
There was a problem hiding this comment.
I don't see how my remarks imply that you should/need to worry about Julia's GC and/or Boehm GC... All I am saying is that for the GAP-Julia interface being created as part of the OSCAR project, SetExtraMarkFuncBags won't be used, because there we don't actually use GASMAN; hence "or Julia" should be dropped from that comment.
There was a problem hiding this comment.
(To clarify: I don't mind if it stays in, or is removed on a later date; feel free to merge right away; I am merely pointing out that it is not based on an actual application that I am aware of).
Codecov Report
@@ Coverage Diff @@
## master #2706 +/- ##
==========================================
- Coverage 75.66% 75.66% -0.01%
==========================================
Files 478 478
Lines 241439 241441 +2
==========================================
- Hits 182685 182681 -4
- Misses 58754 58760 +6
|
fingolfin
added
topic: kernel
release notes: not needed
markuspf
force-pushed
the
extra-mark-func-bags
branch
from
dc77f3d
to
a075bae
Compare
Requested for LibGAP #2702