Forbid constructors with 0 arguments #2700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
the
release notes: to be added
stevelinton
approved these changes
Aug 14, 2018
fingolfin
force-pushed
the
mh/zero-arg-constructors
branch
from
e36b52f to
369c4d1
Compare
Codecov Report
@@ Coverage Diff @@
## master #2700 +/- ##
==========================================
- Coverage 75.52% 75.51% -0.02%
==========================================
Files 478 478
Lines 241590 242082 +492
==========================================
+ Hits 182465 182811 +346
- Misses 59125 59271 +146
|
Constructors with 0 arguments make no sense. Thus, forbid creating such constructors, and also forbid installing zero argument methods for constructors.
fingolfin
force-pushed
the
mh/zero-arg-constructors
branch
from
369c4d1 to
fa54447
Compare
fingolfin
added
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors with 0 arguments make no sense. Thus, forbid creating such
constructors, and also forbid installing zero argument methods for
constructors.