Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve FFE code a bit and add tests #2690

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Commits on Aug 11, 2018

  1. Improve FFE code a bit and add tests

    * add more FFE test cases, now finfield.c has almost full coverage
    * simplify `FuncLOG_FFE_DEFAULT` input validation
    * remove some comments pointing out problem when extending FFV to UInt4: we
      don't plan to do that (and it'd be impractical in the current setup anyway),
      and even if: those comments are not really helpful
    * make Z(p,d) stricter about verifying that `p` is a prime; and fixing an edge
      case on 32 bit systems, where Z(65536,2) lead to an overflow (which luckily
      had no consequences whatsoever)
    * adjust the error message of the kernel function `PowFFEFFE` (for
      "conjugating" FFE elements) to match those for +, -, *, / in case of
      arguments which have different characteristic.
    * fix bug in RootOfDefiningPolynomial
    fingolfin committed Aug 11, 2018
    Configuration menu
    Copy the full SHA
    aaf559c View commit details
    Browse the repository at this point in the history