Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bicoset code #2686

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Improve bicoset code #2686

merged 1 commit into from
Aug 9, 2018

Commits on Aug 8, 2018

  1. Improve bicoset code

    - add `bicoset` to the reference manual index
    - clarify documentation for `IsBiCoset` ("for example" -> "if and only if")
    - improve `IsBiCoset` by replacing `r*x/r` with `x^r`
    - improve multiplication of right cosets to only transfer knowledge about
      whether this is a bicoset if this was already known for the right operand,
      instead of unconditionally computing it; but also transfer if it is not
      (a bicoset times a non-bicoset is not a bicoset)
    - replace `TryNextMethod` in multiplication method for right cosets with
      helpful error message, just like we do in the inversion method
    - improve error message when inverting a right coset which is not a bicoset
    - add a test that ensures we indeed produce an error when multiplying or
      inverting right cosets for which these operations are not defined
    fingolfin committed Aug 8, 2018
    Configuration menu
    Copy the full SHA
    890b181 View commit details
    Browse the repository at this point in the history