Fixed the generators in OmegaZero(2m+1,2^k) #2613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Jul 4, 2018
Member
fingolfin
left a comment
fingolfin
left a comment
There was a problem hiding this comment.
Looks good to me, just have two minor (and optional) remarks.
| # | ||
| gap> Omega(3,2); | ||
| Omega(0,3,2) | ||
| GO(0,3,2) |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| x2:= IdentityMat( d, f ); | ||
| x2[ m+1 ][m]:= o; | ||
| x2[ m+2 ][m]:= o; | ||
| x:= x1 * x2; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fingolfin
added
kind: bug
For odd d and even q, the generators for the matrix groups Omega(0,d,q) from the Rylands/Taylor paper were not correct; one would have to transpose the matrices in order to get a group that respects a form as required. Instead of transposing the generators, we delegate to `SO`, which has the advantage to reduce the possible confusion about the choice of different forms for related orthogonal groups.
ThomasBreuer
force-pushed
the
TB_OmegaZero
branch
from
26a7117 to
f00afa9
Compare
Member
|
LGTM! |
Codecov Report
@@ Coverage Diff @@
## master #2613 +/- ##
==========================================
+ Coverage 74.8% 74.8% +<.01%
==========================================
Files 479 479
Lines 242251 242238 -13
==========================================
- Hits 181206 181198 -8
+ Misses 61045 61040 -5
|
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For odd d and even q,
the generators for the matrix groups Omega(0,d,q)
from the Rylands/Taylor paper were not correct;
one would have to transpose the matrices in order to get
a group that respects a form as required.
Instead of transposing the generators, we delegate to
SO,which has the advantage to reduce the possible confusion
about the choice of different forms for related orthogonal groups.
Resolves #2576