PageSource should show local file #2606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far, we assumed in PageSource that if FILENAME_FUNC returns a string not starting with '/' that the pathname was relative to a GAP root. This is not true if a function was read from a file relative to GAPs current directory. Remark: It would be good to store a full path with function read from a local file.
Codecov Report
@@ Coverage Diff @@
## master #2606 +/- ##
==========================================
- Coverage 74.8% 74.79% -0.01%
==========================================
Files 479 479
Lines 242243 242245 +2
==========================================
- Hits 181198 181195 -3
- Misses 61045 61050 +5
|
ssiccha
approved these changes
Jul 4, 2018
Contributor
ssiccha
left a comment
ssiccha
left a comment
There was a problem hiding this comment.
Sounds and looks sensible to me.
fingolfin
added
kind: bug
fingolfin
approved these changes
Jul 5, 2018
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, we assumed in PageSource that if FILENAME_FUNC returns a string not
starting with '/' that the pathname was relative to a GAP root. This is not
true if a function was read from a file relative to GAPs current directory.
Remark: It would be good to store a full path with function read from a
local file.