Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overview of GAP 4.9.2 release #2591

Merged
merged 1 commit into from
Jul 4, 2018
Merged

Overview of GAP 4.9.2 release #2591

merged 1 commit into from
Jul 4, 2018

Conversation

olexandr-konovalov
Copy link
Member

May require an update if #2578 will be merged before the release.

@olexandr-konovalov olexandr-konovalov added the topic: documentation Issues and PRs related to documentation label Jun 28, 2018
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.2 milestone Jun 28, 2018
@olexandr-konovalov olexandr-konovalov mentioned this pull request Jun 28, 2018
Closed
@olexandr-konovalov
Copy link
Member Author

Update: added #2578.

@fingolfin
Copy link
Member

But note that #2578 is not yet in 4.9 - somebody still has to cherrypick it

@olexandr-konovalov
Copy link
Member Author

Useful reminder - now #2578 cherry-picked.

@codecov
Copy link

codecov bot commented Jun 28, 2018 •
edited
Loading

Codecov Report

Merging #2591 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2591      +/-   ##
==========================================
- Coverage    74.8%   74.79%   -0.01%     
==========================================
  Files         479      479              
  Lines      242243   242243              
==========================================
- Hits       181198   181197       -1     
- Misses      61045    61046       +1
Impacted Files Coverage Δ
src/iostream.c 62.35% <0%> (-1.15%) ⬇️
hpcgap/lib/hpc/stdtasks.g 64.7% <0%> (+0.51%) ⬆️

@fingolfin
Copy link
Member

A "changes" entry for PR #2488 by @hulpke needs to be added now, as that was backported to 4.9. Here is a suggestion, feel free to improve or replace it as you like:

Fix a bug in computing maximal subgroups, which broke other things (e.g. computing intermediate subgroups). Reported by Seyed Hassan Alavi

@olexandr-konovalov
Copy link
Member Author

#2488 also mentioned in the overview - this PR seems to be complete then.

@olexandr-konovalov
Copy link
Member Author

Now also waiting for #2596 outcome.

fingolfin
fingolfin approved these changes Jul 2, 2018
View reviewed changes
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, except that PR #2596 should perhaps also be merged and added here.

@olexandr-konovalov olexandr-konovalov added the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Jul 2, 2018
@olexandr-konovalov
Copy link
Member Author

Added #2596. Hope that's the last one for GAP 4.9.2.

@olexandr-konovalov olexandr-konovalov removed the do not merge PRs which are not yet ready to be merged (e.g. submitted for discussion, or test results) label Jul 3, 2018
fingolfin
fingolfin reviewed Jul 3, 2018
View reviewed changes
doc/changes/changes49.xml Outdated
<Item>
Fixed a crash when an error occurs and
<Ref BookName="ref" Oper="OutputLogTo" Label="for streams"/>
points to a stream which uses a stream
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional: "a stream which uses a stream"? -> I know this comes from the description of the issue, but I find it highly confusing. Perhaps "points to a stream which internally uses another stream"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@olexandr-konovalov
Copy link
Member Author

olexandr-konovalov commented Jul 3, 2018 •
edited
Loading

Updated, also added a comment The <Package>JupyterKernel</Package> package is not yet usable on Windows.

If you're interested where we are with getting it to work on Windows, the current stage is getting ZeroMQInterface package built under Cygwin: see gap-packages/ZeroMQInterface#23

@olexandr-konovalov olexandr-konovalov merged commit ba4c526 into gap-system:master Jul 4, 2018
@olexandr-konovalov olexandr-konovalov deleted the changes-4.9.2 branch July 4, 2018 11:14
@olexandr-konovalov olexandr-konovalov added backport-to-4.9 release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes labels Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fingolfin fingolfin fingolfin approved these changes

@markuspf markuspf Awaiting requested review from markuspf

Assignees
No one assigned
Labels
release notes: not needed PRs introducing changes that are wholly irrelevant to the release notes topic: documentation Issues and PRs related to documentation
Projects
None yet
Milestone
GAP 4.9.2
Development

Successfully merging this pull request may close these issues.
2 participants
@olexandr-konovalov @fingolfin