Add --enable-libgap to build system #2526
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building GAP as an executable with --enable-libgap will yield a binary that ignores most signals. Added libgap files to .gitignore Added sysinfo.gap target to libgap target Added symlinks target to libgap target
fingolfin
requested changes
Jun 7, 2018
| @@ -85,3 +85,8 @@ doc/gapmacrodoc.idx | |||
| /hpcgap/ward | |||
|
|
|||
| /builds/ | |||
|
|
|||
| #libGAP | |||
| @@ -24,6 +24,9 @@ ADDGUARDS2 = @ADDGUARDS2@ | |||
| # garbage collector source files | |||
| GC_SOURCES = @GC_SOURCES@ | |||
|
|
|||
| # Dynamic library | |||
There was a problem hiding this comment.
Dynamic -> dynamic (to match rest of the file)
| @@ -412,6 +412,10 @@ gap$(EXEEXT): $(OBJS) cnf/GAP-LDFLAGS cnf/GAP-LIBS cnf/GAP-OBJS | |||
|
|
|||
| endif | |||
|
|
|||
| ifeq ($(BUILD_LIBGAP),yes) | |||
| libgap.so: $(OBJS) | |||
There was a problem hiding this comment.
This is problematic. First off, .so is not quite portable; e.g. on macOS, it should be .dylib, and on Windows .dll
Anyway, we already do generated a shared library (see libgap.la) using libtool, in a fully portable fashion, including setting rpaths etc. -- so can't we just use that? I guess I don't quite know how you "use" libgap later on, so it's a bit difficult for me to evaluate.
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
==========================================
- Coverage 74.34% 74.33% -0.01%
==========================================
Files 481 481
Lines 243408 243429 +21
==========================================
+ Hits 180958 180963 +5
- Misses 62450 62466 +16
|
fingolfin
reviewed
Jun 7, 2018
| [enable_libgap=no] | ||
| ) | ||
| AC_MSG_CHECKING([whether to enable dynamic library mode]) | ||
| AC_MSG_RESULT([$enable_libgap]) |
There was a problem hiding this comment.
With PR #2528 we may not even need this anymore, nor BUILD_LIBGAP
|
Ok, so this is obsolete :). |
olexandr-konovalov
added
the
gapdays2018-spring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building GAP as an executable with --enable-libgap will yield a binary
that ignores most signals.
Added libgap files to .gitignore
Added sysinfo.gap target to libgap target
Added symlinks target to libgap target
This is part of building LibGAP, see https://github.com/gap-system/gap/projects/5