Change Test() to reject unexpected or invalid inputs #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
fingolfin
requested review from
ChrisJefferson,
olexandr-konovalov,
frankluebeck and
ssiccha
Codecov Report
@@ Coverage Diff @@
## master #2519 +/- ##
==========================================
+ Coverage 74.41% 74.46% +0.04%
==========================================
Files 481 481
Lines 242659 245614 +2955
==========================================
+ Hits 180586 182907 +2321
- Misses 62073 62707 +634
|
|
I suggest we merge this, and then see if any packages fail |
ChrisJefferson
approved these changes
Jun 7, 2018
frankluebeck
approved these changes
Jun 7, 2018
olexandr-konovalov
approved these changes
Jun 7, 2018
There was a problem hiding this comment.
Agree. Cf. also #2524 which is somehow complementary to this.
olexandr-konovalov
added
the
gapdays2018-spring
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat experimental change to fix #2506 -- let's see if the GAP test suite passes with it.
Assuming this works for the test suite, I wonder if there are any reasonable scenarios where the new
Errorcall is triggered and where this is undesirable. If anybody knows such an example, please bring it up. In that case, we could add an option to turn off that error; or restrict the cases in which it is triggered.