HPC-GAP: sync coll.gd and type.g #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
topic: HPC-GAP
fingolfin
force-pushed
the
mh/hpcgap-sync2
branch
from
c4bcb54
to
136f58f
Compare
Codecov Report
@@ Coverage Diff @@
## master #2501 +/- ##
==========================================
- Coverage 74.26% 74.25% -0.01%
==========================================
Files 484 482 -2
Lines 245343 245204 -139
==========================================
- Hits 182208 182081 -127
+ Misses 63135 63123 -12
|
fingolfin
force-pushed
the
mh/hpcgap-sync2
branch
from
136f58f
to
a6ea534
Compare
... they are used by HPC-GAP, and in GAP do nothing different than their counterparts, namely: IsNonAtomicComponentObjectRep <-> IsComponentObjectRep IsReadOnlyPositionalObjectRep <-> IsPositionalObjectRep IsAtomicPositionalObjectRep <-> IsPositionalObjectRep We mainly provide them in plain GAP to make it easier to write code that works well in both GAP and HPC-GAP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subsumes PR #2500.
It is necessary for PR #2387, which otherwise would introduce diffs between GAP and HPC-GAP.