Skip to content

Add more wordrep tests, and fix two bugs founds in the process #2499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fingolfin merged 5 commits into from
Jun 1, 2018
Merged

Add more wordrep tests, and fix two bugs founds in the process #2499

fingolfin merged 5 commits into from
Jun 1, 2018

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented May 30, 2018

No description provided.

@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) topic: tests issues or PRs related to tests labels May 30, 2018
@codecov
Copy link

codecov bot commented May 30, 2018 •
edited
Loading

Codecov Report

Merging #2499 into master will increase coverage by 0.12%.
The diff coverage is 81.13%.

@@            Coverage Diff             @@
##           master    #2499      +/-   ##
==========================================
+ Coverage   74.27%   74.39%   +0.12%     
==========================================
  Files         484      483       -1     
  Lines      245343   244776     -567     
==========================================
- Hits       182225   182101     -124     
+ Misses      63118    62675     -443
Impacted Files Coverage Δ
lib/wordrep.gi 66.44% <100%> (+2.96%) ⬆️
src/objfgelm.c 94.1% <100%> (+16.02%) ⬆️
lib/hpc/thread1.g 59.52% <28.57%> (-6.2%) ⬇️
src/stats.c 89.6% <0%> (+0.19%) ⬆️

@fingolfin
Copy link
Member Author

fingolfin commented May 30, 2018

One thing to note is that 8Bits_Quotient, 16Bits_Quotient and 32Bits_Quotient actually are never used. We might either install them as methods for /, or else remove them.

@fingolfin fingolfin mentioned this pull request Jun 1, 2018
Closed
@fingolfin fingolfin merged commit 34cfdde into gap-system:master Jun 1, 2018
@fingolfin fingolfin deleted the mh/wordrep branch June 1, 2018 20:04
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@hulpke hulpke Awaiting requested review from hulpke

@ssiccha ssiccha Awaiting requested review from ssiccha

Assignees

No one assigned

Labels

kind: bug: crash Issues describing bugs that cause GAP to crash, and PRs fixing them (used for release notes) kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: tests issues or PRs related to tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fingolfin @ChrisJefferson