Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: (Maximal) subgroups computation. #2488

Merged
merged 2 commits into from
Jun 29, 2018
Merged

Commits on Jun 29, 2018

  1. FIX: MaximalSubgroupClassReps with options.

    The routine for `MaximalSubgroupClassReps allows options to calculate
    maximal subgroups only up to specified limits, or if it is not too
    difficult. This causes problems is such a partial list is stored as
    attribute. Thus separate into two attributes: One to calculate the
    guaranteed full list, one to calculate a potentially partial list subject to
    restrictions. Also make sure that limiting options do not get accidentally
    inherited. (In the big scheme of things we might want to revisit the
    question of ``cheap attributes'' more generally, as composition tree uses
    similar paradigms.)
    
    Finally allow a soft fallback to old intermediate subgroup routines, if
    maximal subgroups are not available. (This can go away once proper maximal
    subgroups code is available.)
    
    Also added test file
    
    In the best of all worlds this should be backported to 4.9
    
    Reworked the example. Avoiding the AtlasGroup command makes it much harder
    as SU gives a group on >>325 points. Also construct the subgroup directly to
    avoid homomorphism search.
    hulpke committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    e0b121d View commit details
    Browse the repository at this point in the history
  2. FIX: Pull subgroups of TOM for lattice back through isomorphism

    This bug likely did not show up earlier since the TOM library was not loaded
    by default.
    
    Even an example is provided, the latter thrice as error does not arise every
    time.
    
    This fixes gap-system#2586
    hulpke committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    dc2c83d View commit details
    Browse the repository at this point in the history