Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in IsFinitelyGeneratedGroup method #2275

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Fix bug in IsFinitelyGeneratedGroup method #2275

merged 1 commit into from
Mar 21, 2018

Conversation

fingolfin
Copy link
Member

There was an incorrect method for IsFinitelyGeneratedGroup which assumed that
a group given by an infinite generating set is not finitely generated, which
is of course false: any finitely generated infinite group is generated by its
set of elements.

@fingolfin
Fix bug in IsFinitelyGeneratedGroup method
5b93b00 
There was an incorrect method for IsFinitelyGeneratedGroup which assumed that
a group given by an infinite generating set is not finitely generated, which
is of course false: any finitely generated infinite group is generated by its
set of elements.
@fingolfin fingolfin added kind: bug Issues describing general bugs, and PRs fixing them kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them topic: library labels Mar 21, 2018
@fingolfin fingolfin mentioned this pull request Mar 21, 2018
Closed
ThomasBreuer
ThomasBreuer approved these changes Mar 21, 2018
View reviewed changes
Copy link
Contributor

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is correct.

@codecov
Copy link

codecov bot commented Mar 21, 2018 •
edited
Loading

Codecov Report

Merging #2275 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2275      +/-   ##
==========================================
+ Coverage   70.85%   70.86%   +<.01%     
==========================================
  Files         480      480              
  Lines      253196   253552     +356     
==========================================
+ Hits       179407   179679     +272     
- Misses      73789    73873      +84
Impacted Files Coverage Δ
lib/grp.gi 84.63% <100%> (+0.01%) ⬆️
src/hpc/traverse.c 94.97% <0%> (-0.51%) ⬇️
src/hpc/threadapi.c 36.99% <0%> (+0.09%) ⬆️
lib/oper.g 78.73% <0%> (+0.18%) ⬆️
lib/grpfree.gi 90.47% <0%> (+0.36%) ⬆️
lib/oprt.gi 73.47% <0%> (+0.44%) ⬆️

@fingolfin fingolfin merged commit cecd48d into gap-system:master Mar 21, 2018
@fingolfin fingolfin deleted the mh/fix-IsFinitelyGeneratedGroup branch March 21, 2018 16:16
@fingolfin fingolfin mentioned this pull request Mar 22, 2018
Merged
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

Assignees
No one assigned
Labels
kind: bug: wrong result Issues describing bugs that result in mathematically or otherwise wrong results, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes topic: library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fingolfin @ThomasBreuer