Skip to content

Fix TypeOfOperation for setters of and-filters #2273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fingolfin merged 1 commit into from
Mar 23, 2018
Merged

Fix TypeOfOperation for setters of and-filters #2273

fingolfin merged 1 commit into from
Mar 23, 2018

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented Mar 21, 2018

Resolves #2233

@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Mar 21, 2018
@fingolfin fingolfin requested a review from markuspf March 21, 2018 11:08
@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #2273 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2273      +/-   ##
==========================================
+ Coverage   70.85%   70.85%   +<.01%     
==========================================
  Files         480      480              
  Lines      253196   253197       +1     
==========================================
+ Hits       179407   179408       +1     
  Misses      73789    73789
Impacted Files Coverage Δ
lib/type.gi 72.72% <100%> (+0.5%) ⬆️
src/hpc/traverse.c 95.45% <0%> (-0.03%) ⬇️

@fingolfin fingolfin merged commit c9ef811 into gap-system:master Mar 23, 2018
@fingolfin fingolfin deleted the mh/and-filter-setter branch March 23, 2018 14:56
@fingolfin fingolfin added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisJefferson ChrisJefferson ChrisJefferson approved these changes

@markuspf markuspf Awaiting requested review from markuspf

Assignees

No one assigned

Labels

kind: bug Issues describing general bugs, and PRs fixing them release notes: added PRs introducing changes that have since been mentioned in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fingolfin @ChrisJefferson