Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix implication for IsSubsetLocallyFiniteGroup; and teach Units(GF(q)) its size #2220

Merged
merged 3 commits into from
Mar 2, 2018
Merged

Fix implication for IsSubsetLocallyFiniteGroup; and teach Units(GF(q)) its size #2220

merged 3 commits into from
Mar 2, 2018

Commits on Mar 1, 2018

  1. Fix implication for IsSubsetLocallyFiniteGroup 

    IsFFECollection and IsMagma does *not* imply IsSubsetLocallyFiniteGroup,
as e.g. any finite field GF(q) satisfies the former, but clearly not
the latter (due to containing 0).

However, using IsMagmaWithInverses fixes this.
    @fingolfin
    fingolfin committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    ffb9e3b View commit details
    Browse the repository at this point in the history

  2. Teach Units(GF(q)) its size

    @fingolfin
    fingolfin committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    40fa874 View commit details
    Browse the repository at this point in the history

  3. IsFFEMatrixGroup implies IsSubsetLocallyFiniteGroup 

    ... and this then automatically gives the implication
  IsFFEMatrixGroup and IsFinitelyGeneratedGroup => IsFinite
    @fingolfin
    fingolfin committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    355cfe7 View commit details
    Browse the repository at this point in the history