Fix bug in ValueMolienSeries #2183
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: bug
ThomasBreuer
requested changes
Feb 15, 2018
Contributor
ThomasBreuer
left a comment
ThomasBreuer
left a comment
There was a problem hiding this comment.
The fix is correct.
Additionally, the record component pol should be set in the result of the function MolienSeriesWithGivenDenominator.
fingolfin
force-pushed
the
mh/ValueMolienSeries
branch
from
5e22239 to
4338810
Compare
Member
Author
|
Fixed |
ThomasBreuer
approved these changes
Feb 15, 2018
fingolfin
force-pushed
the
mh/ValueMolienSeries
branch
from
4338810 to
69d49a6
Compare
In particular, test that ValueMolienSeries still gives the same result.
fingolfin
added
the
release notes: added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #300