Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement StandardAssociate(Unit) for ZmodnZ, tweak documentation for IsEuclideanRing #1990

Merged
merged 2 commits into from
Dec 18, 2017

Conversation

fingolfin
Copy link
Member

Another PR coming from "spring cleaning" in my local branches. Adjusting the documentation for IsEuclideanRing is necessary because for e.g. polynomials, the euclidean degree can be -infinity.

Having StandardAssociate and StandardAssociateUnit for ZmodnZ simply is useful for writing various generic algorithms.

@fingolfin fingolfin added topic: documentation Issues and PRs related to documentation kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements topic: library labels Dec 5, 2017
@codecov
Copy link

codecov bot commented Dec 17, 2017

Codecov Report

Merging #1990 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
- Coverage   66.01%   65.98%   -0.03%     
==========================================
  Files         898      898              
  Lines      273347   273634     +287     
  Branches    12766    12770       +4     
==========================================
+ Hits       180439   180554     +115     
- Misses      90078    90249     +171     
- Partials     2830     2831       +1
Impacted Files Coverage Δ
lib/zmodnz.gi 95.57% <100%> (+0.15%) ⬆️
hpcgap/lib/zmodnz.gi 95.08% <100%> (+0.16%) ⬆️
lib/float.gi 29.89% <0%> (-1.77%) ⬇️
src/macfloat.c 75.25% <0%> (-0.57%) ⬇️
src/hpc/thread.c 45.81% <0%> (-0.4%) ⬇️
src/funcs.c 76.37% <0%> (-0.27%) ⬇️
src/gap.c 58.32% <0%> (-0.16%) ⬇️
src/stats.c 79.43% <0%> (ø) ⬆️
src/stringobj.c 79.14% <0%> (+0.11%) ⬆️
lib/ring.gi 51.93% <0%> (+0.22%) ⬆️
... and 4 more

Copy link
Member

@olexandr-konovalov olexandr-konovalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although I think it will be useful not only to check the output of each function, but also to check that the condition StandardAssociateUnit( r ) * r = StandardAssociate( r ) holds.

@fingolfin
Copy link
Member Author

Excellent idea, and it revealed a bug in the code -- the unit it computed was the reciprocal of the correct one :-/. This is fixed, and additional tests have been added.

@olexandr-konovalov olexandr-konovalov merged commit f0b86fe into gap-system:master Dec 18, 2017
@fingolfin fingolfin deleted the mh/ZmodnZ branch December 18, 2017 16:29
@olexandr-konovalov olexandr-konovalov added the release notes: added PRs introducing changes that have since been mentioned in the release notes label Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements release notes: added PRs introducing changes that have since been mentioned in the release notes topic: documentation Issues and PRs related to documentation topic: library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants