-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in compiler, and add tests #1789
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1789 +/- ##
==========================================
+ Coverage 62.93% 62.97% +0.04%
==========================================
Files 969 969
Lines 293986 293986
Branches 12986 12962 -24
==========================================
+ Hits 185013 185140 +127
+ Misses 106162 106022 -140
- Partials 2811 2824 +13
|
Instead of renaming .out to .output, you could also just adjust the rule in
|
Touching the |
@ChrisJefferson not sure why you think changing entries in And even if, then we should actively combat that, instead of avoiding to make certain changes. That said, if you prefer |
Specifically, I already change |
@ChrisJefferson I am sorry but this now conflicts :/. Would you terribly mind updating it, then we can merge it ASAP. |
1f680b6
to
aff5144
Compare
This patch fixes #1781 (which was easy, as there was a fix already in that PR!), but more usefully adds a simple testing infrastructure for the GAP->C compiler, and adds some simple tests (including for the fixed bug).
Obviously, the number of tests here is very small, but it provides a basic sanity check and a place for people to add more tests if they want.