Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UpEnv, some other lvars tweaks #1780

Merged
merged 10 commits into from
Oct 24, 2017
Merged

Fix UpEnv, some other lvars tweaks #1780

merged 10 commits into from
Oct 24, 2017

Commits on Oct 20, 2017

  1. Introduce struct LVarsHeader

    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    3e49110 View commit details
    Browse the repository at this point in the history

  2. Use {STAT,FUNC}_LVARS macros in more places

    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    d360892 View commit details
    Browse the repository at this point in the history

  3. Fix FuncParentLVars for bottom lvars 

    Now returns fail again
    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    25a2bba View commit details
    Browse the repository at this point in the history

  4. Reset ErrorLLevel when entering/leaving break loops

    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    1882367 View commit details
    Browse the repository at this point in the history

  5. Fix DownEnv / UpEnv handling 

    Also get rid of STATE(ErrorLVars0)

This is an example for DownEnv/UpEnv usage:

gap> f:=lvl -> 1/lvl + f(lvl-1);
function( lvl ) ... end
gap> f(3);
Error, Rational operations: <divisor> must not be zero in
  return 1 / lvl + f( (lvl - 1) ); called from
f( lvl - 1 ) called from
f( lvl - 1 ) called from
f( lvl - 1 ) called from
<function "f">( <arguments> )
 called from read-eval loop at line 12 of *stdin*
you can replace <divisor> via 'return <divisor>;'
brk> lvl;
0
brk> UpEnv(1); lvl;
0
brk> DownEnv(1); lvl;
1
brk> DownEnv(1); lvl;
2
brk> UpEnv(1); lvl;
1
brk> DownEnv(1); lvl;
2
brk> DownEnv(1); lvl;
3
brk> DownEnv(1); lvl;
3
brk> UpEnv(1); lvl;
2

Note that before this commit, the very last UpEnv(1) incorrectly returned
us to level 0.
    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    b8c9f97 View commit details
    Browse the repository at this point in the history

  6. .gitignore: change *.out -> main.out

    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    a2182e1 View commit details
    Browse the repository at this point in the history

  7. test-error/run_gap.sh: pipe test data in, instead of using Read

    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    71df3bb View commit details
    Browse the repository at this point in the history

  8. Add test for UpEnv/DownEnv

    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    d5d8c5b View commit details
    Browse the repository at this point in the history

  9. test-error: add 'good' test

    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    913f62b View commit details
    Browse the repository at this point in the history

  10. Extend UpEnv/DownEnv test

    @fingolfin
    fingolfin committed Oct 20, 2017
    Configuration menu
    Copy the full SHA
    f03ff72 View commit details
    Browse the repository at this point in the history