Add asserts to dispatch tables #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First off, these set equality to be identity, which is the default anyway. Secondly, these <EqFuncs> were never actually used anyway, because the ariths kernel module gets initialized after the vars kernel module, and during that, it resets <EqFuncs>.
This helps track down weird issues caused by a kernel module modifying a dispatch table before the kernel module owning the dispatch table has been initialized. For example, the previous commit resolved such an issue for EqFuncs and HVARS / LVARS.
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
==========================================
+ Coverage 64.19% 64.19% +<.01%
==========================================
Files 992 992
Lines 322105 322148 +43
Branches 13064 13070 +6
==========================================
+ Hits 206762 206814 +52
+ Misses 112518 112513 -5
+ Partials 2825 2821 -4
|
markuspf
approved these changes
Jul 24, 2017
fingolfin
added
topic: kernel
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes some dead code, and adds assertions that help detect similar dead code.