Enable -O2 on travis #1393
Merged
Enable -O2 on travis #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
added
kind: enhancement
GAP is by default built using -O2, but on Travis, we set custom CFLAGS, which unintentionally overrode this default. This PR turns -O2 back on, which results in tests completing up to two times faster. However, this leads to vecgf2.c triggering an internal compiler error in the 32bit HPC-GAP build. So we turn off -O2 for that.
Codecov Report
@@ Coverage Diff @@
## master #1393 +/- ##
==========================================
+ Coverage 55.1% 62.09% +6.99%
==========================================
Files 1027 1028 +1
Lines 349735 351201 +1466
Branches 14224 14218 -6
==========================================
+ Hits 192717 218078 +25361
+ Misses 153642 129604 -24038
- Partials 3376 3519 +143
|
ChrisJefferson
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GAP is by default built using -O2, but on Travis, we set custom CFLAGS,
which unintentionally overrode this default.
This PR turns -O2 back on, which results in tests completing about two
times faster.
However, this leads to vecgf2.c triggering an internal compiler error in
the 32bit HPC-GAP build. To compensate, we switch that build to use clang
instead of GCC.