New tests for group constructors and some fixes

grp/basic.gd

@@ -138,9 +138,6 @@ BindGlobal( "AbelianGroup", function ( arg )
 
     if Length(arg) = 2  then
       return AbelianGroupCons( arg[1], arg[2] );
-
-    elif Length(arg) = 3  then
-      return AbelianGroupCons( arg[1], arg[2], arg[3] );
     fi;
   fi;
   Error( "usage: AbelianGroup( [<filter>, ]<ints> )" );
@@ -200,7 +197,7 @@ BindGlobal( "AlternatingGroup", function ( arg )
       return  AlternatingGroupCons( arg[1], arg[2] );
     fi;
   fi;
-  Error( "usage:  AlternatingGroup( [<filter>, ]<deg> )" );
+  Error( "usage: AlternatingGroup( [<filter>, ]<deg> )" );
 
 end );
 
@@ -263,9 +260,6 @@ BindGlobal( "CyclicGroup", function ( arg )
 
     if Length(arg) = 2  then
       return CyclicGroupCons( arg[1], arg[2] );
-
-    elif Length(arg) = 3  then
-      return CyclicGroupCons( arg[1], arg[2], arg[3] );
     fi;
   fi;
   Error( "usage: CyclicGroup( [<filter>, ]<size> )" );
@@ -320,9 +314,6 @@ BindGlobal( "DihedralGroup", function ( arg )
 
     if Length(arg) = 2  then
       return DihedralGroupCons( arg[1], arg[2] );
-
-    elif Length(arg) = 3  then
-      return DihedralGroupCons( arg[1], arg[2], arg[3] );
     fi;
   fi;
   Error( "usage: DihedralGroup( [<filter>, ]<size> )" );
@@ -380,9 +371,6 @@ BindGlobal( "QuaternionGroup", function ( arg )
 
     if Length(arg) = 2  then
       return QuaternionGroupCons( arg[1], arg[2] );
-
-    elif Length(arg) = 3  then
-      return QuaternionGroupCons( arg[1], arg[2], arg[3] );
     fi;
   fi;
   Error( "usage: QuaternionGroup( [<filter>, ]<size> )" );
@@ -437,9 +425,6 @@ BindGlobal( "ElementaryAbelianGroup", function ( arg )
 
     if Length(arg) = 2  then
       return ElementaryAbelianGroupCons( arg[1], arg[2] );
-
-    elif Length(arg) = 3  then
-      return ElementaryAbelianGroupCons( arg[1], arg[2], arg[3] );
     fi;
   fi;
   Error( "usage: ElementaryAbelianGroup( [<filter>, ]<size> )" );
@@ -492,12 +477,9 @@ BindGlobal( "FreeAbelianGroup", function ( arg )
 
     if Length(arg) = 2  then
       return FreeAbelianGroupCons( arg[1], arg[2] );
-
-    elif Length(arg) = 3  then
-      return FreeAbelianGroupCons( arg[1], arg[2], arg[3] );
     fi;
   fi;
-  Error( "usage: FreeAbelianGroup( [<filter>, ]<size> )" );
+  Error( "usage: FreeAbelianGroup( [<filter>, ]<rank> )" );
 
 end );
 
@@ -560,9 +542,6 @@ BindGlobal( "ExtraspecialGroup", function ( arg )
 
     if Length(arg) = 3  then
       return ExtraspecialGroupCons( arg[1], arg[2], arg[3] );
-
-    elif Length(arg) = 4  then
-      return ExtraspecialGroupCons( arg[1], arg[2], arg[3], arg[4] );
     fi;
   fi;
   Error( "usage: ExtraspecialGroup( [<filter>, ]<order>, <exponent> )" );
@@ -616,9 +595,6 @@ BindGlobal( "MathieuGroup", function( arg )
 
     if Length( arg ) = 2 then
       return MathieuGroupCons( arg[1], arg[2] );
-
-    elif Length( arg ) = 3 then
-      return MathieuGroupCons( arg[1], arg[2], arg[3] );
     fi;
   fi;
   Error( "usage: MathieuGroup( [<filter>, ]<degree> )" );
@@ -683,7 +659,7 @@ BindGlobal( "SymmetricGroup", function ( arg )
       return  SymmetricGroupCons( arg[1], arg[2] );
     fi;
   fi;
-  Error( "usage:  SymmetricGroup( [<filter>, ]<deg> )" );
+  Error( "usage: SymmetricGroup( [<filter>, ]<deg> )" );
 
 end );
 

grp/classic.gi

@@ -403,7 +403,7 @@ BindGlobal( "Oplus45", function()
 
     # construct the group without calling 'Group'
     g := [ phi*tau2, tau*eichler*delta ];
-    g:=List(g,i->ImmutableMatrix(f,i),true);
+    g:=List(g,i->ImmutableMatrix(f,i));
     g := GroupWithGenerators( g );
     SetDimensionOfMatrixGroup( g, 4 );
     SetFieldOfMatrixGroup( g, f );
@@ -1418,16 +1418,16 @@ InstallMethod( GeneralOrthogonalGroupCons,
 
     # <e> must be -1, 0, +1
     if e <> -1 and e <> 0 and e <> +1  then
-        Error( "sign <e> must be -1, 0, +1\n" );
+        Error( "sign <e> must be -1, 0, +1" );
     fi;
 
     # if <e> = 0  then <d> must be odd
     if e = 0 and d mod 2 = 0  then
-        Error( "sign <e> = 0 but dimension <d> is even\n" );
+        Error( "sign <e> = 0 but dimension <d> is even" );
 
     # if <e> <> 0  then <d> must be even
     elif e <> 0 and d mod 2 = 1  then
-        Error( "sign <e> <> 0 but dimension <d> is odd\n" );
+        Error( "sign <e> <> 0 but dimension <d> is odd" );
     fi;
 
     # construct the various orthogonal groups
@@ -1945,11 +1945,11 @@ InstallMethod( OmegaCons,
 
     # if <e> = 0  then <d> must be odd
     if e = 0 and d mod 2 = 0  then
-        Error( "sign <e> = 0 but dimension <d> is even\n" );
+        Error( "sign <e> = 0 but dimension <d> is even" );
 
     # if <e> <> 0  then <d> must be even
     elif e <> 0 and d mod 2 = 1  then
-        Error( "sign <e> <> 0 but dimension <d> is odd\n" );
+        Error( "sign <e> <> 0 but dimension <d> is odd" );
     fi;
 
     # construct the various orthogonal groups

grp/glzmodmz.gi

@@ -127,7 +127,7 @@ local f,M2,o,e,MM,i;
 end);
 
 BindGlobal("SPRingGeneric",function(n,ring)
-local t,geni,m,slmats,gens,f,rels,i,j,k,l,mat,mat1,mats,id,nh;
+local t,geni,m,slmats,gens,f,rels,i,j,k,l,mat,mat1,mats,id,nh,g;
   nh:=n;
   n:=2*n;
   t:=function(i,j)
@@ -136,7 +136,7 @@ local t,geni,m,slmats,gens,f,rels,i,j,k,l,mat,mat1,mats,id,nh;
   geni:=List([1..n],x->[]);
   mats:=[];
   slmats:=[];
-  id:=IdentityMat(n,One(ring));
+  id:=IdentityMat(n,ring);
   m:=0;
   for i in [1..nh] do
     #t_{i,n+i}
@@ -170,7 +170,10 @@ local t,geni,m,slmats,gens,f,rels,i,j,k,l,mat,mat1,mats,id,nh;
     od;
   od;
 
-  return Group(slmats);
+  g := Group(slmats);
+  mat := Concatenation(id{[nh+1..n]},-id{[1..nh]});
+  SetInvariantBilinearForm(g,rec(matrix:=mat));
+  return g;
 end);
 
 InstallGlobalFunction("ConstructFormPreservingGroup",function(arg)

grp/perf.gd

@@ -11,7 +11,6 @@
 
 
 PERFRec := fail; # indicator that perf0.grp is not loaded
-PERFSELECT := [];
 PERFGRP := [];
 
 

grp/perf.grp

@@ -14,7 +14,7 @@
 #F  PerfGrpLoad(<size>)  force loading of secondary files, return index
 ##
 InstallGlobalFunction( PerfGrpLoad, function(sz)
-local p,sel,i,pos;
+local p,pos;
   if PERFRec=fail then
     ReadGrp("perf0.grp");
   fi;
@@ -23,30 +23,12 @@ local p,sel,i,pos;
   if pos=fail then
     return fail;
   fi;
-  if PERFSELECT[pos] then
+  if IsBound(PERFGRP[pos]) then
     return pos;
   fi;
   # get the file number
   p:=PositionSorted(PERFRec.covered,pos);
-  if SizeBlist(PERFSELECT)>50 then
-    # throw away old to free memory
-    sel:=Filtered([1..PERFRec.length],i->PERFSELECT[i]);
-    sel:=sel{[1..Length(sel)-25]};
-    for i in sel do
-      Unbind(PERFGRP[i]);
-      PERFSELECT[i]:=false;
-    od;
-  fi;
   ReadGrp(Concatenation("perf",String(p),".grp"));
-  # store loaded info
-  if p=1 then
-    p:=[0,PERFRec.covered[p]];
-  else
-    p:=PERFRec.covered{[p-1,p]};
-  fi;
-  for i in [p[1]+1..p[2]] do
-    PERFSELECT[i]:=true;
-  od;
   return pos;
 end );
 

grp/suzuki.gd

@@ -66,4 +66,3 @@ DeclareSynonym( "Sz", SuzukiGroup );
 #############################################################################
 ##
 #E
-

grp/suzuki.gi

@@ -32,7 +32,7 @@ function ( filter, q )
 
   if not IsPrimePowerInt(q)
     or SmallestRootInt(q) <> 2 or LogInt(q,2) mod 2 = 0
-  then Error("<q> must be a non-square power of 2\n"); fi;
+  then Error("<q> must be a non-square power of 2"); fi;
 
   f := GF(q);
   G := GroupByGenerators(
@@ -74,7 +74,7 @@ function ( filter, q )
 
   if not IsPrimePowerInt(q)
     or SmallestRootInt(q) <> 2 or LogInt(q,2) mod 2 = 0
-  then Error("<q> must be a non-square power of 2\n"); fi;
+  then Error("<q> must be a non-square power of 2"); fi;
 
   f := GF(q);
   r := RootInt(2 * q);
@@ -101,4 +101,4 @@ end );
 
 #############################################################################
 ##
-#E  suzuki.gi . . . . . . . . . . . . . . . . . . . . . . . . . . . ends here
+#E  suzuki.gi . . . . . . . . . . . . . . . . . . . . . . . . . . . ends here

tst/teststandard/ctbl.tst → tst/testinstall/ctbl.tst

@@ -5,8 +5,6 @@
 ##
 #Y  Copyright (C)  1998,  Lehrstuhl D für Mathematik,  RWTH Aachen,  Germany
 ##
-##  Exclude from testinstall.g: why?
-##
 gap> START_TEST("ctbl.tst");
 
 # `ClassPositionsOf...' for the trivial group (which usually causes trouble)

tst/testinstall/eigen.tst

@@ -6,8 +6,6 @@
 ##
 #Y  Copyright (C)  1998,  Lehrstuhl D für Mathematik,  RWTH Aachen,  Germany
 ##
-##  Exclude from testinstall.g: why?
-##
 gap> START_TEST("eigen.tst");
 gap> A := GL(4,3).1;
 [ [ Z(3), 0*Z(3), 0*Z(3), 0*Z(3) ], [ 0*Z(3), Z(3)^0, 0*Z(3), 0*Z(3) ], 

tst/teststandard/fldabnum.tst → tst/testinstall/fldabnum.tst

@@ -5,7 +5,6 @@
 ##
 #Y  Copyright (C)  1996,  Lehrstuhl D für Mathematik,  RWTH Aachen,  Germany
 ##
-##  Exclude from testinstall.g: why?
 ##
 gap> START_TEST("fldabnum.tst");
 gap> CF( 1 ); CF( 6 ); CF( 4 ); CF( 5 ); CF( 36 );