Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support GO( 1, q ), SO( 1, q ), Omega( 1, q ), Omega( -1, 2, q ) #4321

Closed
ThomasBreuer opened this issue Mar 17, 2021 · 1 comment · Fixed by #4333
Closed

Support GO( 1, q ), SO( 1, q ), Omega( 1, q ), Omega( -1, 2, q ) #4321

ThomasBreuer opened this issue Mar 17, 2021 · 1 comment · Fixed by #4333
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements

Comments

@ThomasBreuer
Copy link
Contributor

Currently GAP supports GO( e, n, q ), SO( e, n, q ), Omega( e, n, q ) only for n larger than 1, and also Omega( -1, 2, q ) is not supported.

(This was observed in oscar-system/Oscar.jl/pull/351.)

I think it would be good to admit also n = 1 and Omega( -1, 2, q ).
(The ATLAS states on p. xi that "the groups are boring for n at most 2", but they can be useful in recursions.)

I can provide a pull request if there are no objections.
@ThomasBreuer ThomasBreuer mentioned this issue Mar 17, 2021
Merged
@fingolfin
Copy link
Member

No objections, such a PR would be welcome, thanks!

@fingolfin fingolfin added the kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements label Mar 21, 2021
@ThomasBreuer ThomasBreuer mentioned this issue Mar 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind: enhancement Label for issues suggesting enhancements; and for pull requests implementing enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GO(1,q), SO(1,q), Omega(1,q), Omega(-1,2,q) ThomasBreuer/gap
2 participants
@fingolfin @ThomasBreuer