Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RankOfPartialPermSemigroup fails for a partial perm group with no generators #3037

Closed
wilfwilson opened this issue Nov 21, 2018 · 1 comment · Fixed by #3038
Closed

RankOfPartialPermSemigroup fails for a partial perm group with no generators #3037

wilfwilson opened this issue Nov 21, 2018 · 1 comment · Fixed by #3038
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them

Comments

@wilfwilson
Copy link
Member

Using GAP master branch:

gap> G := Group([], PartialPerm([1, 2]));;
gap> RankOfPartialPermSemigroup(G);
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `RankOfPartialPermCollection' on 1 argum\
ents at /Users/Wilf/gap/lib/methsel2.g:250 called from
RankOfPartialPermCollection( GeneratorsOfGroup( S )
 ) at /Users/Wilf/gap/lib/semipperm.gi:104 called from
<function "unknown">( <arguments> )
 called from read-eval loop at *stdin*:5
type 'quit;' to quit to outer loop
brk>

This should return 2. I noticed this when trying to view the group:

gap> G;
Error, no method found! For debugging hints type ?Recovery from NoMethodFound
Error, no 1st choice method found for `RankOfPartialPermCollection' on 1 argum\
ents at /Users/Wilf/gap/lib/methsel2.g:250 called from
RankOfPartialPermCollection( GeneratorsOfGroup( S )
 ) at /Users/Wilf/gap/lib/semipperm.gi:104 called from
RankOfPartialPermSemigroup( S ) at /Users/Wilf/gap/lib/semipperm.gi:30 called from
SemigroupViewStringSuffix( S ) at /Users/Wilf/gap/lib/semigrp.gi:166 called from
ViewString( G ) at /Users/Wilf/gap/lib/grp.gi:4321 called from
SetUserHasQuit( 1 ); at /Users/Wilf/gap/lib/error.g:328 called from
...  at *stdin*:5
type 'quit;' to quit to outer loop
brk>

For a partial perm group G, RankOfPartialPermSemigroup should probably return RankOfPartialPerm(One(G));

@wilfwilson wilfwilson added the kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them label Nov 21, 2018
wilfwilson added a commit to wilfwilson/gap that referenced this issue Nov 21, 2018
wilfwilson added a commit to wilfwilson/gap that referenced this issue Nov 21, 2018
@fingolfin
Copy link
Member

This also affects older GAP versions, like 4.8.

@fingolfin fingolfin added the kind: bug Issues describing general bugs, and PRs fixing them label Mar 21, 2019
ssiccha pushed a commit to ssiccha/gap that referenced this issue Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug: unexpected error Issues describing bugs in which computation unexpectedly encounters an error, and PRs fixing them kind: bug Issues describing general bugs, and PRs fixing them
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants