Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CodePcGroup fails for trivial pc group #1664

Closed
wilfwilson opened this issue Sep 5, 2017 · 0 comments
Closed

CodePcGroup fails for trivial pc group #1664

wilfwilson opened this issue Sep 5, 2017 · 0 comments
Assignees
Labels
gapdays2017-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2017-fall
Milestone

Comments

@wilfwilson
Copy link
Member

wilfwilson commented Sep 5, 2017

In today's master:

Observed behaviour

gap> G := TrivialGroup(IsPcGroup);
<pc group of size 1 with 0 generators>
gap> CodePcGroup(G);
Error, MaximumList: <list> must contain at least one element at /Users/Wilf/GAP/lib/list.gi:2596 called from
MaximumList( arg[1] ) at /Users/Wilf/GAP/lib/list.gi:2510 called from
Maximum( indices ) at /Users/Wilf/GAP/lib/randiso.gi:244 called from
CodePcgs( Pcgs( G ) ) at /Users/Wilf/GAP/lib/randiso.gi:294 called from
<function "CodePcGroup">( <arguments> )

Expected behaviour

gap> G := TrivialGroup(IsPcGroup);
<pc group of size 1 with 0 generators>
gap> CodePcGroup(G);
0

(Since PcGroupCode(0, 1) gives a trivial pc group, I'd guess this is the right code).

(Thanks for teaching me about CodePcGroup @fingolfin!)

@wilfwilson wilfwilson changed the title CodePcGroup fails for trivial PcGroup CodePcGroup fails for trivial pc group Sep 5, 2017
@olexandr-konovalov olexandr-konovalov added the gapdays2017-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2017-fall label Sep 5, 2017
wilfwilson added a commit to wilfwilson/gap that referenced this issue Sep 6, 2017
wilfwilson added a commit to wilfwilson/gap that referenced this issue Sep 6, 2017
@wilfwilson wilfwilson self-assigned this Sep 6, 2017
@olexandr-konovalov olexandr-konovalov added this to the GAP 4.9.0 milestone Jan 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gapdays2017-fall Issues and PRs that arose at https://www.gapdays.de/gapdays2017-fall
Projects
None yet
Development

No branches or pull requests

2 participants