Apply suggestions from code review

Co-authored-by: Max Horn <max@quendi.de>
gap-system · Mar 24, 2021 · f58748e · f58748e
1 parent 1ee92e6
commit f58748e
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/lib/list.gd b/lib/list.gd
@@ -2382,7 +2382,7 @@ DeclareGlobalFunction( "ListWithIdenticalEntries" );
 ##
 ##  <Description>
 ##  This function returns a list equal to its argument, in a plain list
-##  representation.
+##  representation (see <Ref Filt="IsPlistRep"/>).
 ##  This is intended for use in certain rare situations,
 ##  such as before objectifying, or calling some kernel functions.
 ##  </Description>

diff --git a/src/lists.c b/src/lists.c
@@ -1590,7 +1590,8 @@ Obj PLAIN_LIST_COPY(Obj list)
     return res;
 }
 
-Obj FuncPLAIN_LIST_COPY(Obj func, Obj list) {
+Obj FuncPLAIN_LIST_COPY(Obj func, Obj list)
+{
     return PLAIN_LIST_COPY(list);
 }
 

diff --git a/tst/testinstall/list.tst b/tst/testinstall/list.tst
@@ -331,6 +331,10 @@ gap> checkPlainListCopy("abc");
 true
 gap> checkPlainListCopy(ListWithIdenticalEntries(3, false));
 true
+gap> checkPlainListCopy(NewZeroVector(IsGF2VectorRep, GF(2), 10));
+true
+gap> checkPlainListCopy(NewZeroVector(Is8BitVectorRep, GF(3), 10));
+true
 
 # Check TNUM behaviours
 gap> x := [1,,"cheese"];;