FIX: Correct subspace inclusion -- larger space is not necc. triag.

gap-system · Oct 8, 2016 · b05b1b3 · b05b1b3
1 parent b58d589
commit b05b1b3
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/lib/grppcaut.gi b/lib/grppcaut.gi
@@ -1034,7 +1034,7 @@ local spaceincl,outvecs,l,sub,yet,i,j,k,s,t,new,incl,min,rans,sofar,done,
   end;
 
   spaceincl:=function(big,small)
-    return big=canonicalform(Concatenation(big,small));
+    return canonicalform(big)=canonicalform(Concatenation(big,small));
   end;
 
   outvecs:=function(space,new)
@@ -1120,6 +1120,7 @@ local spaceincl,outvecs,l,sub,yet,i,j,k,s,t,new,incl,min,rans,sofar,done,
 	new:=outvecs(sub,spaces[i]);
 	Add(rans,[Length(sofar)+1..Length(sofar)+Length(new)]);
 	Append(sofar,new);
+	if Length(sofar)>RankMat(sofar) then Error("ENA");fi;
       fi;
     od;
 

diff --git a/tst/teststandard/grpauto.tst b/tst/teststandard/grpauto.tst
@@ -41,6 +41,19 @@ fail
 gap> IsomorphismGroups(G,PcGroupCode(CodePcGroup(G),Size(G)))=fail;
 false
 
+#
+# Many Spaces
+#
+
+gap> G:=PcGroupCode(338681823291028181778801710348121147721184790127576437,
+> 29160);;
+gap> H:=PcGroupCode(338681822494525443798297952136327929199594863010776437,
+> 29160);;
+gap> IsomorphismGroups(G,H);
+fail
+gap> IsomorphismGroups(G,PcGroupCode(CodePcGroup(G),Size(G)))=fail;
+false
+
 #
 # hard-iso3
 #