Give better error message if a helpfile is missing

... or if it inaccessible (e.g. due to missing read access)
gap-system · Nov 9, 2016 · a624385 · a624385
1 parent 3f7ca3d
commit a624385
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/lib/helpdef.gi b/lib/helpdef.gi
@@ -297,9 +297,14 @@ InstallGlobalFunction(HELP_CHAPTER_INFO, function( book, chapter )
 
         filename := Filename( info.directories, info.filenames[chapter] );
         if filename = fail  then
+            Error("help file ", info.filenames[chapter], " for help book '", book.bookname, "' not found");
             return fail;
         fi;
         stream := StringStreamInputTextFile(filename);
+        if stream = fail then
+            Error("help file ", filename, " does not exist or is not readable");
+            return fail;
+        fi;
         poss   := [];
         secnum := 0;
         repeat

diff --git a/lib/helpt2t.gi b/lib/helpt2t.gi
@@ -219,7 +219,7 @@ local   book, chapter, section, key, subkey, MatchKey, ssectypes,
   info := HELP_BOOK_INFO(book);
   chap := HELP_CHAPTER_INFO( book, chapter );
   if chap = fail  then
-      return;
+      return fail;
   fi;
 
   # store lines