Further github remarks.

gap-system · Apr 24, 2018 · 718a107 · 718a107
1 parent eb2aed2
commit 718a107
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 17 deletions.
diff --git a/lib/grp.gd b/lib/grp.gd
@@ -784,6 +784,8 @@ InstallFactorMaintenance( IsSolvableGroup,
 InstallTrueMethod( IsSolvableGroup, IsMonomialGroup );
 InstallTrueMethod( IsSolvableGroup, IsSupersolvableGroup );
 
+InstallTrueMethod( HasIsPerfectGroup, IsGroup and IsSolvableGroup and IsNonTrivial );
+
 
 #############################################################################
 ##

diff --git a/lib/grp.gi b/lib/grp.gi
@@ -439,13 +439,6 @@ InstallMethod( IsNilpotentGroup,
 ##
 #M  IsPerfectGroup( <G> ) . . . . . . . . . . . .  test if a group is perfect
 ##
-#  This used to be an immediate method. It was replaced by a TrueMethod (in
-#  the gd file)
-#InstallImmediateMethod( IsPerfectGroup,
-#    IsSolvableGroup and HasIsTrivial,
-#    0,
-#    IsTrivial );
-
 InstallImmediateMethod( IsPerfectGroup,
     IsGroup and HasIsAbelian and IsSimpleGroup,
     0,

diff --git a/tst/testinstall/coll.tst b/tst/testinstall/coll.tst
@@ -97,16 +97,13 @@ Error, cannot test whether <C> contains the family of its elements
 # Size
 #
 
-# test removed as immediate method removed
-## immediate method for collections knowing they are infinite
-#gap> c2:=ConjugacyClass(F, F.1);;
-#gap> HasSize(c2);
-#false
-#gap> SetIsFinite(c2, false);
-#gap> HasSize(c2);
-#true
-#gap> Size(c2);
-#infinity
+## method for collections knowing they are infinite
+gap> c2:=ConjugacyClass(F, F.1);;
+gap> HasSize(c2);
+false
+gap> SetIsFinite(c2, false);
+gap> Size(c2);
+infinity
 
 # immediate method for collections with HasAsList
 gap> M2:=Magma(0, 1);;