Remove invalid implication for IsSubsetLocallyFiniteGroup

IsFFECollection and IsMagma does *not* imply IsSubsetLocallyFiniteGroup, as e.g. any finite field GF(q) satisfies the former, but clearly not the latter
gap-system · Feb 28, 2018 · 516570c · 516570c
1 parent 144b52a
commit 516570c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/lib/grp.gd b/lib/grp.gd
@@ -251,13 +251,6 @@ InstallSubsetMaintenance( IsSubsetLocallyFiniteGroup,
     IsGroup and IsSubsetLocallyFiniteGroup, IsGroup );
 
 
-#############################################################################
-##
-#M  IsSubsetLocallyFiniteGroup( <G> ) . . . . . . . . . .  for magmas of FFEs
-##
-InstallTrueMethod( IsSubsetLocallyFiniteGroup, IsFFECollection and IsMagma );
-
-
 #############################################################################
 ##
 ##  <#GAPDoc Label="[3]{grp}">

diff --git a/tst/testbugfix/2018-02-28-IsSubsetLocallyFiniteGroup.tst b/tst/testbugfix/2018-02-28-IsSubsetLocallyFiniteGroup.tst
@@ -0,0 +1,5 @@
+# there used to be a bad implication from IsFFECollection and IsMagma to
+# IsSubsetLocallyFiniteGroup, which caused all finite fields to be in filter
+# IsSubsetLocallyFiniteGroup -- verify this is not the case anymore.
+gap> HasIsSubsetLocallyFiniteGroup(GF(2));
+false