lib: simplify UnionIfCanEasilySortElements

gap-system · Sep 17, 2019 · 470098f · 470098f
1 parent 3430937
commit 470098f
Showing 1 changed file with 5 additions and 9 deletions.
diff --git a/lib/grpnames.gi b/lib/grpnames.gi
@@ -81,16 +81,12 @@ InstallMethod( IsTrivialNormalIntersection,
 InstallGlobalFunction( UnionIfCanEasilySortElements,
 
   function( arg )
-    local i, N;
 
-    for i in [1..Length(arg)] do
-      for N in arg[i] do
-        if not CanEasilySortElements(N) then
-          return Concatenation(arg);
-        fi;
-      od;
-    od;
-    return Union(arg);
+    if ForAll(arg, CanEasilySortElements) then
+      return Union(arg);
+    else
+      return Concatenation(arg);
+    fi;
   end);
 
 #############################################################################