Skip to content

Commit

Permalink
BuildPackages.sh: "make clean" before full build
Browse files Browse the repository at this point in the history
This way, if a user re-runs BuildPackages.sh in order to re-build packages,
there is a higher chance that this works as expected, instead of mixing old
compilation results with new ones.

For GAP packages with non-autoconf based build systems, we re-run configure
after the `make clean`, as for many of them, the latter removes their
generated Makefile (in violation of well-established UNIX conventions).
  • Loading branch information
fingolfin committed May 30, 2019
1 parent 5d81b55 commit 1ac9cfc
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions bin/BuildPackages.sh
Original file line number Diff line number Diff line change
Expand Up @@ -168,8 +168,11 @@ run_configure_and_make() {
if grep Autoconf ./configure > /dev/null
then
echo_run ./configure --with-gaproot="$GAPROOT" $CONFIGFLAGS
echo_run "$MAKE" clean
else
echo_run ./configure "$GAPROOT"
echo_run "$MAKE" clean
echo_run ./configure "$GAPROOT"
fi
echo_run "$MAKE"
else
Expand Down

0 comments on commit 1ac9cfc

Please sign in to comment.