Merge pull request #1784 from wilfwilson/fix-1783

Fix IsomorphismPartialPermSemigroup and Monoid for perm groups with 0 generators
gap-system · Oct 26, 2017 · 124962f · 124962f
2 parents e5389a6 + d3b22af
commit 124962f
Show file tree

Hide file tree

Showing 3 changed files with 66 additions and 3 deletions.
diff --git a/lib/semipperm.gi b/lib/semipperm.gi
@@ -356,7 +356,11 @@ function(G)
   local dom, S;
 
   dom := MovedPoints(G);
-  S := InverseMonoid(List(GeneratorsOfGroup(G), p -> AsPartialPerm(p, dom)));
+  if IsEmpty(GeneratorsOfGroup(G)) then
+    S := InverseMonoid(EmptyPartialPerm());
+  else
+    S := InverseMonoid(List(GeneratorsOfGroup(G), p -> AsPartialPerm(p, dom)));
+  fi;
   UseIsomorphismRelation(G, S);
   SetIsGroupAsSemigroup(S, true);
 
@@ -373,8 +377,12 @@ function(G)
   local dom, S;
 
   dom := MovedPoints(G);
-  S := InverseSemigroup(List(GeneratorsOfGroup(G), 
-                             p -> AsPartialPerm(p, dom)));
+  if IsEmpty(GeneratorsOfGroup(G)) then
+    S := InverseSemigroup(EmptyPartialPerm());
+  else
+    S := InverseSemigroup(List(GeneratorsOfGroup(G),
+                               p -> AsPartialPerm(p, dom)));
+  fi;
   UseIsomorphismRelation(G, S);
   SetIsGroupAsSemigroup(S, true);
 

diff --git a/tst/testbugfix/2017-10-19-IsomorphismPartialPermSemigroup.tst b/tst/testbugfix/2017-10-19-IsomorphismPartialPermSemigroup.tst
@@ -0,0 +1,27 @@
+# Issue related to IsomorphismPartialPermSemigroup and
+# IsomorphismPartialPermMonoid for a trivial perm group with 0 generators
+# Examples reported on issue #1783 on github.com/gap-system/gap
+gap> iso := [];;
+gap> iso[1] := IsomorphismPartialPermSemigroup(SymmetricGroup(1));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> iso[2] := IsomorphismPartialPermSemigroup(Group([()]));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> iso[3] := IsomorphismPartialPermSemigroup(Group([], ()));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> iso[4] := IsomorphismPartialPermMonoid(SymmetricGroup(1));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> iso[5] := IsomorphismPartialPermMonoid(Group([()]));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> iso[6] := IsomorphismPartialPermMonoid(Group([], ()));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> ForAll(iso, map -> () ^ map = EmptyPartialPerm());
+true
+gap> inv := List(iso, InverseGeneralMapping);;
+gap> ForAll(inv, map -> EmptyPartialPerm() ^ map = ());
+true
diff --git a/tst/testinstall/semipperm.tst b/tst/testinstall/semipperm.tst
@@ -333,13 +333,41 @@ gap> BruteForceIsoCheck(last);
 true
 gap> BruteForceInverseCheck(last2);
 true
+gap> IsomorphismPartialPermSemigroup(Group([()]));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> BruteForceIsoCheck(last);
+true
+gap> BruteForceInverseCheck(last2);
+true
+gap> IsomorphismPartialPermSemigroup(Group([], ()));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> BruteForceIsoCheck(last);
+true
+gap> BruteForceInverseCheck(last2);
+true
 gap> IsomorphismPartialPermMonoid(Group((1,2,3)));
 MappingByFunction( Group([ (1,2,3) ]), <partial perm group of rank 3 with
   1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
 gap> BruteForceIsoCheck(last);
 true
 gap> BruteForceInverseCheck(last2);
 true
+gap> IsomorphismPartialPermMonoid(Group([()]));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> BruteForceIsoCheck(last);
+true
+gap> BruteForceInverseCheck(last2);
+true
+gap> IsomorphismPartialPermMonoid(Group([], ()));
+MappingByFunction( Group(()), <trivial partial perm group of rank 0 with
+  1 generator>, function( p ) ... end, <Attribute "AsPermutation"> )
+gap> BruteForceIsoCheck(last);
+true
+gap> BruteForceInverseCheck(last2);
+true
 
 # Test SymmetricInverseMonoid
 gap> SymmetricInverseMonoid(-1);