Merge pull request #25 from fingolfin/mh/fix-props

Turn IsEquivalence{Head,Tail} and IsXModAlgebraConst into filters
gap-packages · Aug 27, 2018 · ecea7dc · ecea7dc
2 parents 5a9e338 + 8f67e9f
commit ecea7dc
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 18 deletions.
diff --git a/lib/alg2obj.gd b/lib/alg2obj.gd
@@ -104,9 +104,9 @@ DeclareOperation( "PreXModAlgebraByPreCat1Algebra", [ IsPreCat1Algebra ] );
 DeclareAttribute( "Equivalence", IsPreCat1Algebra );
 DeclareAttribute( "SourceForEquivalence", IsCat1Algebra );
 DeclareAttribute( "BoundaryForEquivalence", IsCat1Algebra );
-DeclareAttribute( "IsEquivalenceHead", IsCat1Algebra );
-DeclareAttribute( "IsEquivalenceTail", IsCat1Algebra );
-DeclareAttribute( "IsXModAlgebraConst", IsCat1Algebra );
+DeclareFilter( "IsEquivalenceHead", IsCat1Algebra );
+DeclareFilter( "IsEquivalenceTail", IsCat1Algebra );
+DeclareFilter( "IsXModAlgebraConst", IsCat1Algebra );
 DeclareAttribute( "XModAlgebraConst", IsCat1Algebra );
 DeclareAttribute( "XModAlgebraOfCat1Algebra", IsPreCat1Algebra );
 DeclareOperation( "XModAlgebraByCat1Algebra", [ IsPreCat1Algebra ] );

diff --git a/lib/alg2obj.gi b/lib/alg2obj.gi
@@ -1827,7 +1827,6 @@ function( t, h, e )
     imbdy := List( kergen, x -> Image( h, x) );
     bdy := AlgebraHomomorphismByImagesNC( kert, R, kergen, imbdy );
     SetEquivalence( tres, false );
-    SetIsXModAlgebraConst( tres, false );
     PC := PreCat1AlgebraObj( tres, hres, eres );
     SetBoundary( PC, bdy );
     SetKernelEmbedding( PC, f );
@@ -1971,19 +1970,14 @@ end );
 ##
 #M  Kernel( t,h ) . . . . . . . . . . . . . . . . . . . for a pre-cat1-algebra
 ##
-InstallOtherMethod( Kernel, "method for a pre-cat1-algebra", true, 
-    [ IsEquivalenceHead and  IsEquivalenceTail and IsAlgebraHomomorphism ], 0,
-function( f )
-
-    local A;
-    if  IsEquivalenceHead(f) then
-        return EquivalenceHead(f);
-    fi;
-    if  IsEquivalenceTail(f) then
-        return EquivalenceTail(f);
-    fi;
-end );
-
+InstallOtherMethod( Kernel, "method for a pre-cat1-algebra",
+    [ IsEquivalenceHead and IsAlgebraHomomorphism ],
+    EquivalenceHead );
+
+InstallOtherMethod( Kernel, "method for a pre-cat1-algebra",
+    [ IsEquivalenceTail and IsAlgebraHomomorphism ],
+    EquivalenceTail );
+
 #############################################################################
 ##
 #M  EquivalenceTail. . . . convert a pre-crossed module to a pre-cat1-algebra
@@ -2009,7 +2003,7 @@ end );
 ##
 InstallMethod( EquivalenceHead,
     "convert a pre-crossed module to a pre-cat1-algebra", true,
-    [  IsEquivalenceHead ], 0,
+    [ IsEquivalenceHead ], 0,
 function( f )
 
     local  A, R, RA, eA, uzA, Xbdy, list, i, a, x, Ker ;