Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly pluralize the ViewString for pregroup presentations #34

Closed
wants to merge 1 commit into from
Closed

Properly pluralize the ViewString for pregroup presentations #34

wants to merge 1 commit into from

Conversation

wilfwilson
Copy link
Member

This makes use of the Pluralize function that was introduced in gap-system/gap#3992, and will be included in GAP 4.12.

Obviously we can't require GAP 4.12 yet, because it doesn't exist, and even once it is released the use of Pluralize isn't in itself a good enough reason to require it.

So for now I have duplicated the relevant subset of the Pluralize function in this package. This can be removed once this package requires GAP 4.12 or later.

@codecov
Copy link

codecov bot commented Oct 21, 2020

Codecov Report

Merging #34 into master will decrease coverage by 0.16%.
The diff coverage is 58.33%.

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   90.10%   89.93%   -0.17%     
==========================================
  Files          22       22              
  Lines        2364     2374      +10     
==========================================
+ Hits         2130     2135       +5     
- Misses        234      239       +5     
Impacted Files Coverage Δ
gap/examples.gd 100.00% <ø> (ø)
gap/presentation.gd 100.00% <ø> (ø)
gap/walrus.gd 100.00% <ø> (ø)
gap/presentation.gi 91.28% <58.33%> (-1.99%) ⬇️

@wilfwilson wilfwilson closed this May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant