Accommodate correctly pluralized ViewStrings in GAP #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a future version of GAP, some nouns will be correctly pluralised to match their number. For example, the
ViewString
forCyclicGroup(3);
will change from<pc group of size 3 with 1 generators>
to<pc group of size 3 with 1 generator>
. (See gap-system/gap#3992 and gap-system/gap#4050 for more context.)In this PR, I am trying maintain the backwards and forwards compatibility of this package with GAP. I have done this by suppressing the incorrectly spelled output in tests, and adopting the new output in the
.tex
files (which I assume are not run through any automated tests?)Please let me know if this is sufficient - perhaps it was actually important to keep some of the output that I have now suppressed?